Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace individual autofill buttons on name and ORCID with single button #205

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes #198

Summary

Previously the Name and ORCID iD fields of the Study form individually had autofill buttons. These changes replace those two buttons with a single autofill button.

Details

This also includes minor changes to make padding and margins more uniform in the Study form.

Additionally, with the changes in microbiomedata/nmdc-server#1442, the backend now associates an optional email address with User records. These changes also add the email field to the app's User model. If the email field of the logged in user is present and populated, it will be used to fill out the Study form's email field when the autofill button is pressed.

Before Clicking After Clicking
image image

Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm glad to see their email address (if present) will be auto-filled also. I'm comfortable with this PR branch being merged in as is.

@pkalita-lbl pkalita-lbl merged commit b079543 into main Dec 3, 2024
1 check passed
@pkalita-lbl pkalita-lbl deleted the issue-198-pi-name-button branch December 3, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the magic wand icons in PI name and ORCID with more explicit action button
2 participants